Re: backend hangs at immediate shutdown (Re: Back-branch update releases coming in a couple weeks)

From: "MauMau" <maumau307(at)gmail(dot)com>
To: "Alvaro Herrera" <alvherre(at)2ndquadrant(dot)com>, "Noah Misch" <noah(at)leadboat(dot)com>
Cc: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Andres Freund" <andres(at)2ndquadrant(dot)com>, "Peter Eisentraut" <peter_e(at)gmx(dot)net>, <pgsql-hackers(at)postgreSQL(dot)org>, "Robert Haas" <robertmhaas(at)gmail(dot)com>
Subject: Re: backend hangs at immediate shutdown (Re: Back-branch update releases coming in a couple weeks)
Date: 2013-06-27 10:45:10
Message-ID: 6FDBFDBC492C4C87ABC93EDF537C70CE@maumau
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi, Alvaro san,

From: "Alvaro Herrera" <alvherre(at)2ndquadrant(dot)com>
> MauMau escribió:
> Yeah, I see that --- after removing that early exit, there are unwanted
> messages. And in fact there are some signals sent that weren't
> previously sent. Clearly we need something here: if we're in immediate
> shutdown handler, don't signal anyone (because they have already been
> signalled) and don't log any more messages; but the cleaning up of
> postmaster's process list must still be carried out.
>
> Would you please add that on top of the attached cleaned up version of
> your patch?

I did this. Please find attached the revised patch. I modified
HandleChildCrash(). I tested the immediate shutdown, and the child cleanup
succeeded.

In addition, I added if condition at the end of the function. This is to
prevent resetting AbortStartTime every time one child terminates.

Regards
MauMau

Attachment Content-Type Size
reliable_immediate_shutdown-3.patch application/octet-stream 15.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Maciej Gajewski 2013-06-27 10:54:28 Re: Review: query result history in psql
Previous Message Magnus Hagander 2013-06-27 10:34:06 Min value for port