From: | "Finnerty, Jim" <jfinnert(at)amazon(dot)com> |
---|---|
To: | Maxim Orlov <orlovmg(at)gmail(dot)com> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Add 64-bit XIDs into PostgreSQL 15 |
Date: | 2022-01-07 15:39:16 |
Message-ID: | 6F7A244A-1CE4-4744-A305-92E6ADEDE2F4@amazon.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Re: clog page numbers, as returned by TransactionIdToPage
- int pageno = TransactionIdToPage(xid); /* get page of parent */
+ int64 pageno = TransactionIdToPage(xid); /* get page of parent */
...
- int pageno = TransactionIdToPage(subxids[0]);
+ int64 pageno = TransactionIdToPage(subxids[0]);
int offset = 0;
int i = 0;
...
- int nextpageno;
+ int64 nextpageno;
Etc.
In all those places where you are replacing int with int64 for the kind of values returned by TransactionIdToPage(), would you mind replacing the int64's with a type name, such as ClogPageNumber, for improved code maintainability?
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2022-01-07 15:49:10 | Re: enhance pg_log_backend_memory_contexts() to log memory contexts of auxiliary processes |
Previous Message | Joshua Brindle | 2022-01-07 14:51:41 | Re: CREATEROLE and role ownership hierarchies |