Re: Amcheck: do rightlink verification with lock coupling

From: "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>
To: Peter Geoghegan <pg(at)bowt(dot)ie>
Cc: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Amcheck: do rightlink verification with lock coupling
Date: 2020-08-06 04:50:40
Message-ID: 6EFAA3E0-11FC-41D4-8649-3BBABA54EAB3@yandex-team.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> 6 авг. 2020 г., в 04:25, Peter Geoghegan <pg(at)bowt(dot)ie> написал(а):
>
> * Added _bt_checkpage() calls for buffers, as is standard practice in nbtree.
>
> * Added protection against locking the same page a second time in the
> event of a faulty sibling link -- we should avoid a self-deadlock in
> the event of a page that is corrupt in just the wrong way.
>
> * Updated obsolescent comments that claimed that we never couple
> buffer locks in amcheck.
Cool, thanks!
There's mintor typo: missing space in "of_bt_check_unique".

>
> I would like to commit something like this in the next day or two.
>
> Thoughts?

Sounds great! Thanks!

Best regards, Andrey Borodin.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrey M. Borodin 2020-08-06 04:55:51 Re: pg_rewind is not crash safe
Previous Message vignesh C 2020-08-06 04:49:15 Re: Parallel copy