Re: [HACKERS] Compile Failue on win32 - pipe.c using ereport

From: "Merlin Moncure" <merlin(dot)moncure(at)rcsonline(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: <pgsql-hackers-win32(at)postgresql(dot)org>
Subject: Re: [HACKERS] Compile Failue on win32 - pipe.c using ereport
Date: 2004-06-30 15:12:12
Message-ID: 6EE64EF3AB31D5448D0007DD34EEB34101AE9E@Herge.rcsinc.local
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers-win32

> > Try replacing "c.h" with "postgres.h". I fixed that on the win32
> > binaries and forgot to mention it.
>
> There was a recently submitted patch to change postgres.h to c.h in a
> bunch of src/port modules, which I applied without looking closely.
> Apparently it was a tad overenthusiastic.
>
> The big question here is whether pipe.c is interesting for use in
> frontend programs. If so, it can't use ereport/elog at all, and we'll
> need to change the code. If not, we can just revert the inclusion
> mistake.
>
> Are there failures in any other src/port modules now?

No, that's the only one. pipe.c should not be used outside the backend.

Merlin

Responses

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Tom Lane 2004-06-30 15:31:44 Re: [HACKERS] Compile Failue on win32 - pipe.c using ereport
Previous Message Tom Lane 2004-06-30 15:04:37 Re: Compile Failue on win32 - pipe.c using ereport