Re: [COMMITTERS] pgsql: Add 'day' field to INTERVAL so 1 day interval

From: "Rocco Altier" <RoccoA(at)Routescape(dot)com>
To: "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: "PostgreSQL-patches" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Add 'day' field to INTERVAL so 1 day interval
Date: 2005-07-20 18:42:15
Message-ID: 6E0907A94904D94B99D7F387E08C4F5730EA99@FALCON.INSIGHT
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

This is also broken for make check with --enable-integer-datetimes on
kookaburra (AIX).

It looks like the other members of buildfarm that fail on contrib aren't
using integer datetimes.

-rocco

> -----Original Message-----
> From: pgsql-patches-owner(at)postgresql(dot)org
> [mailto:pgsql-patches-owner(at)postgresql(dot)org] On Behalf Of Bruce Momjian
> Sent: Wednesday, July 20, 2005 2:21 PM
> To: Kris Jurka
> Cc: PostgreSQL-patches
> Subject: Re: [PATCHES] [COMMITTERS] pgsql: Add 'day' field to
> INTERVAL so 1 day interval
>
>
> Kris Jurka wrote:
> > Bruce Momjian wrote:
> > > Log Message:
> > > -----------
> > > Add 'day' field to INTERVAL so 1 day interval can be
> distinguished from
> > > 24 hours. This is very helpful for daylight savings time:
> > >
> >
> > Seems to have broken the contrib/btree_gist interval
> regression tests
> >
> >
> http://pgbuildfarm.org/cgi-bin/show_log.pl?nm=dragonfly&dt=200
5-07-20%2017:30:00

I have applied a patch which adds the 'date' value for interval to the
code. However, the regression still does not pass. Here is a query:

SELECT count(*) FROM intervaltmp WHERE a = '199 days
21:21:23'::interval;
count
-------
1
(1 row)

that should return 1, but returns 0 in the current code. Does anyone
have any ideas on a fix?

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania
19073

---------------------------(end of broadcast)---------------------------
TIP 4: Have you searched our list archives?

http://archives.postgresql.org

Browse pgsql-patches by date

  From Date Subject
Next Message Jim C. Nasby 2005-07-20 20:44:27 Re: [HACKERS] Patch to fix plpython on OS X
Previous Message Bruce Momjian 2005-07-20 18:20:39 Re: [COMMITTERS] pgsql: Add 'day' field to INTERVAL so 1 day interval