Re: Fix incorrect order of params in comment

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix incorrect order of params in comment
Date: 2025-05-13 11:38:12
Message-ID: 6DDC4601-3117-4973-A426-ACA0D0F6DA16@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 9 May 2025, at 23:50, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Fri, May 09, 2025 at 07:21:17PM +0200, Daniel Gustafsson wrote:
>> -=item $node->log_check($offset, $test_name, %parameters)
>> +=item $node->log_check($test_name, $offset, %parameters)
>>
>> Check contents of server logs.
>
> Right, good catch. The internals of the routine use %params instead
> of %parameters, so perhaps this should be changed as well in the
> description?

Good point, not that documentation must match 1:1 but the other functions use
%params in their docs and matching that has value. Done.

--
Daniel Gustafsson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2025-05-13 13:37:30 Re: using index to speedup add not null constraints to a table
Previous Message Amit Kapila 2025-05-13 11:33:25 Re: Add an option to skip loading missing publication to avoid logical replication failure