| From: | Paul Guo <guopa(at)vmware(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>, "Asim Praveen (Pivotal)" <apraveen(at)pivotal(dot)io>, "Lei Wang (Pivotal)" <leiwang(at)pivotal(dot)io>, "thomas(dot)munro(at)gmail(dot)com" <thomas(dot)munro(at)gmail(dot)com>, "horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp" <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: standby recovery fails (tablespace related) (tentative patch and discussion) |
| Date: | 2021-03-30 07:12:19 |
| Message-ID: | 6D2B8078-19FA-46CD-A12F-30C43F492D7A@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021/3/27, 10:23 PM, "Alvaro Herrera" <alvherre(at)2ndquadrant(dot)com> wrote:
> Hmm, can you post a rebased set, where the points under discussion
> are marked in XXX comments explaining what the issue is? This thread is
> long and old ago that it's pretty hard to navigate the whole thing in
> order to find out exactly what is being questioned.
OK. Attached are the rebased version that includes the change I discussed
in my previous reply. Also added POD documentation change for RecursiveCopy,
and modified the patch to use the backup_options introduced in
081876d75ea15c3bd2ee5ba64a794fd8ea46d794 for tablespace mapping.
> I think 0004 can be pushed without further ado, since it's a clear and
> simple fix. 0001 needs a comment about the new parameter in
> RecursiveCopy's POD documentation.
Yeah, 0004 is no any risky. One concern seemed to be the compatibility of some
WAL dump/analysis tools(?). I have no idea about this. But if we do not backport
0004 we do not seem to need to worry about this.
> As I understand, this is a backpatchable bug-fix.
Yes.
Thanks.
| Attachment | Content-Type | Size |
|---|---|---|
| v11-0001-Support-node-initialization-from-backup-with-tab.patch | application/octet-stream | 4.9 KB |
| v11-0002-Tests-to-replay-create-database-operation-on-sta.patch | application/octet-stream | 9.7 KB |
| v11-0003-Fix-replay-of-create-database-records-on-standby.patch | application/octet-stream | 10.6 KB |
| v11-0004-Fix-database-create-drop-wal-description.patch | application/octet-stream | 1.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2021-03-30 07:28:44 | Re: Idea: Avoid JOINs by using path expressions to follow FKs |
| Previous Message | Pavel Stehule | 2021-03-30 07:02:39 | Re: Idea: Avoid JOINs by using path expressions to follow FKs |