Re: PG 19 release notes and authors

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Peter Geoghegan <pg(at)bowt(dot)ie>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, PostgreSQL-development <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: PG 19 release notes and authors
Date: 2026-04-06 14:03:27
Message-ID: 6CBFA6BE-2CDD-4991-8827-30180794D1B6@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 6 Apr 2026, at 15:57, Bruce Momjian <bruce(at)momjian(dot)us> wrote:

> Wow, I never thought that was a valid pattern, but I see a few PG 19
> commit messages using that, e.g.:
>
> Author: Peter Eisentraut <peter(at)eisentraut(dot)org>
> 2025-08-12 [5f19d13df] libpq: Set LDAP protocol version 3
>
> libpq: Set LDAP protocol version 3
>
> Some LDAP servers reject the default version 2 protocol. So set
> version 3 before starting the connection. This matches how the
> backend LDAP code has worked all along.
>
> Co-authored-by: Andrew Jackson <andrewjackson947(at)gmail(dot)com>
> Reviewed-by: Pavel Seleznev <pavel(dot)seleznev(at)gmail(dot)com>
> Discussion: https://www.postgresql.org/message-id/flat/CAKK5BkHixcivSCA9pfd_eUp7wkLRhvQ6OtGLAYrWC%3Dk7E76LDQ%40mail.gmail.com
>
> Is that what people are using? A missing Author, and co-authors means
> the committer is the author? Right? Shouldn't we document this? That
> does give a unique use for Co-authored-by.

My online checksums commit use a similar pattern, which is how I had
interpreted our use of it. It lists myself and Magnus as authors with Tomas
Vondra as co-auhor since he provided substantial changes to the patch.

A missing Author tag should IMO always mean that the committer is the author.

>> do think we have enough structured data that if we felt our attribution efforts
>> were insufficient there are more things we could do. I’m not sure this is the
>> most valuable way to expose this data but it’s a way, we likely don’t do enough
>> promotion even with it, and it seems low maintenance. But maybe there is a
>> cost/benefit discussion to be had here.
>
> I guess that is my question. I don't think the author names have the
> same practical value now that we have commit links, but if people think
> it still has _sufficient_ value, we should keep it --- that was my
> question.

I know from talking to several contributors that seeing their name next to the
feature in the release notes is a huge motivator.

--
Daniel Gustafsson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Joe Conway 2026-04-06 14:04:30 Re: PG 19 release notes and authors
Previous Message Robert Haas 2026-04-06 14:01:52 Re: pg_plan_advice