From: | Amit kapila <amit(dot)kapila(at)huawei(dot)com> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: external_pid_file not removed on postmaster exit |
Date: | 2012-07-28 07:41:49 |
Message-ID: | 6C0B27F7206C9E4CA54AE035729E9C382851FB0E@szxeml509-mbs |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
>From: pgsql-hackers-owner(at)postgresql(dot)org [pgsql-hackers-owner(at)postgresql(dot)org] on behalf of Peter Eisentraut [peter_e(at)gmx(dot)net]
> Sent: Friday, July 27, 2012 10:39 AM
> It seems strange that the external_pid_file is never removed. There is
> even a C comment about it:
> /* Should we remove the pid file on postmaster exit? */
> I think it should be removed with proc_exit hook just like the main
> postmaster.pid file.
external_pid_file is created first time when it is enabled in postgresql.conf
I think it should be removed once the parameter external_pid_file is unset;
Making handling of both postmaster.pid and external_pid_file same in terms of creation and removal may not be best choice
as both have different purpose.
With Regards,
Amit Kapila.
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2012-07-28 16:01:04 | Re: Using pg_upgrade on log-shipping standby servers |
Previous Message | Satoshi Nagayasu | 2012-07-28 07:34:14 | Adding probes for smgr |