Re: [PATCHES] vcbuild bison check

From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
To: "Bruce Momjian" <bruce(at)momjian(dot)us>
Cc: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] vcbuild bison check
Date: 2006-10-04 13:05:58
Message-ID: 6BCB9D8A16AC4241919521715F4D8BCEA0FC1F@algol.sollentuna.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

> > > > 2.1 is the broken one.
> > >
> > > Exactly. So we should reject it.
> >
> > We do. The code as-is *only* accepts 1.875. Thus it rejects 2.1.
>
> I think Tom's point is that we should reject only 2.1. Isn't
> that the only version that fails?

Not entirely sure. I beleive there were older versions that don't work
as well... And you can't expect lots of older versions around - I'm sure
*at least* 99% of the ppl who are building withthis will download bison
specifically for this. And given that, they're going to get the latest
by default, or 1.875 if they read the (currently being written) README.

//Magnus

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Zeugswetter Andreas DCP SD 2006-10-04 13:27:57 Re: [PATCHES] vcbuild bison check
Previous Message Magnus Hagander 2006-10-04 13:05:57 qsort_arg needed for msvc build

Browse pgsql-patches by date

  From Date Subject
Next Message Zeugswetter Andreas DCP SD 2006-10-04 13:27:57 Re: [PATCHES] vcbuild bison check
Previous Message Magnus Hagander 2006-10-04 13:05:57 qsort_arg needed for msvc build