Re: src/tools/msvc usage instructions

From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Jeremy Drake" <pgsql(at)jdrake(dot)com>, "PostgreSQL Hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: src/tools/msvc usage instructions
Date: 2006-10-03 17:21:25
Message-ID: 6BCB9D8A16AC4241919521715F4D8BCEA0FC12@algol.sollentuna.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> >> which looks like they figured out that they needed to check for
> >> MicroSoft C explicitly. I have no idea why they do not define
> >> __STDC__ however.
>
> > Can we just define __STDC__ when compiling that file (or
> rather, when
> > compiling any bison-generated output file)? Or is that
> likely to cause
> > *other* issues?
>
> That seems pretty risky. Better to use the /Za switch or
> whatever it was to get the compiler to assert it for itself.
> We have precedent for adding
> yes-we'd-like-a-standard-compiler-please switches where
> necessary, for instance adding -Ae to CFLAGS for HP's compiler.

Unfortunatly, that breaks things so bad it's not even funny. For a file
as simple as src/port/win32error.c I get hundreds of errors - many in
the win32 header files. Seems you ar eont allowed to pull in the win32
API headers without that flag - just the basic ANSI ones. So that' sjust
not going to fly.

//Magnus

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-10-03 17:28:12 Re: PG qsort vs. Solaris
Previous Message Teodor Sigaev 2006-10-03 17:03:46 Re: tsearch2 error msg