Re: Couple of minor fixes

From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Couple of minor fixes
Date: 2006-04-09 21:23:50
Message-ID: 6BCB9D8A16AC4241919521715F4D8BCEA0F8F6@algol.sollentuna.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

> > > 2) timezone/localtime.c, transtime() has a const arcument in the
> > > implementation but non-const in declaration.
> >
> > I did this the other way (make implementation match declaration).
> > I think the coding was in fact correct per spec, because
> const-ness of
> > an argument value is not part of the function signature.
>
> Ok.

Came across another one of those. schemacmds.h has:
extern void AlterSchemaOwner_oid(const Oid schemaOid, Oid newOwnerId);

but schemacmds.c has:
void
AlterSchemaOwner_oid(Oid oid, Oid newOwnerId)

//Magnus

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2006-04-09 21:54:56 Re: Support Parallel Query Execution in Executor
Previous Message Tom Lane 2006-04-09 21:19:00 Re: [WIP] Add relminxid column to pg_class