Query tool result discarding

From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
To: <pgadmin-hackers(at)postgresql(dot)org>
Subject: Query tool result discarding
Date: 2006-02-02 10:12:23
Message-ID: 6BCB9D8A16AC4241919521715F4D8BCE6C7F9D@algol.sollentuna.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi!

A fairly typical use-case for the query tool in my org is:

BEGIN TRANSACTION;
UPDATE something SET somecol=newval WHERE something=other;
SELECT * FROM something; -- this is to manually verify results
ROLLBACK;

Then when everything works, you replace ROLLBACK with COMMIT. This works
perfectly in the query tool in sqlserver, but pgAdmin discards the
result from SELECT and leaves the result pane empty. Because it's
overwritten by the empty result from ROLLBACK.

Attached patch fixes this very limited test case. I'm well enough
unfamiliar with that code that I think it's probably not the correct
solution "in the big scheme" (and it also seems too easy), but it might
help point one of you guys who know that code better in the right
direction. Or on the off chance that it's right, hey, there was some
luck left over :-)

//Magnus

Attachment Content-Type Size
query_discard.patch application/octet-stream 563 bytes

Browse pgadmin-hackers by date

  From Date Subject
Next Message svn 2006-02-02 13:59:06 SVN Commit by dpage: r4984 - trunk/pgadmin3
Previous Message Dave Page 2006-02-02 09:02:48 Re: [pgadmin-support] "view data" freezes up every time