Re: [HACKERS] Inefficiency in recent pgtz patch

From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "PostgreSQL-patches" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] Inefficiency in recent pgtz patch
Date: 2005-06-04 13:05:52
Message-ID: 6BCB9D8A16AC4241919521715F4D8BCE6C75D0@algol.sollentuna.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

>> Do you agree that using a hashtable for it in general is a good idea
>> assuming this sideeffect is removed, though?
>
>I have no problem with the hashtable, only with preloading it with
>everything. What I'd like to see is that the table inherited at fork()
>contains just the data for the default timezone. (At least in the
>normal case where that setting hasn't been changed since postmaster
>start.)

Here's a patch doing this. Changes score_timezone not to use pg_tzset(),
and thus not loading all the zones in the cache. The actual timezone
being picked will be set using set_global_timezone() which in turn calls
pg_tzset() and loads it in the cache.

//Magnus

Attachment Content-Type Size
tzcache.patch application/octet-stream 1.8 KB

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Qingqing Zhou 2005-06-04 13:25:41 Re: Simplify Win32 Signaling code
Previous Message Qingqing Zhou 2005-06-04 06:54:26 Re: psql: \d+ show tablespace of indices