Re: [pgsql-hackers-win32] [HACKERS] snprintf causes regression tests to fail

From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: "Nicolai Tufar" <ntufar(at)gmail(dot)com>, "PostgreSQL-patches" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [pgsql-hackers-win32] [HACKERS] snprintf causes regression tests to fail
Date: 2005-03-02 10:30:38
Message-ID: 6BCB9D8A16AC4241919521715F4D8BCE476A21@algol.sollentuna.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

> Hmm ...
>
> First line of thought: we surely must not insert a snprintf
> into libpq.so unless it is 100% up to spec *and* has no
> performance issues ... neither of which can be claimed of the
> CVS-tip version.
>
> Second line of thought: libpq already feels free to insert
> allegedly up-to-spec versions of a number of things, and no
> one has complained.
> Maybe the linker prevents problems by not linking these
> versions to any calls from outside libpq?
>
> Third thought: Windows' linker seems to be broken enough that
> it may create problems of this ilk that exist on no other platform.

If you're takling the combination of libpq and Windows, we are definitly
safe for dynamic linking, which is what most ppl will use. Because the
DLL will only export the entrypoitns that we explicitly define in the
DEF files, and those are also the only ones that are present in the
"import library".

//Magnus

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message pgsql 2005-03-02 12:09:37 Re: snprintf causes regression tests to fail
Previous Message Markus Bertheau ☭ 2005-03-02 09:48:43 Re: [HACKERS] UTF8 or Unicode