Re: Home dir changes have broken MSVC builds

From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
To: "Andrew Dunstan" <andrew(at)dunslane(dot)net>
Cc: "PostgreSQL-development" <pgsql-hackers(at)postgresql(dot)org>, <tjtoocool(at)phreaker(dot)net>
Subject: Re: Home dir changes have broken MSVC builds
Date: 2005-01-09 19:41:49
Message-ID: 6BCB9D8A16AC4241919521715F4D8BCE476543@algol.sollentuna.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>>>The trouble seems to come from these 2 lines:
>>>
>>>+ #define _WIN32_IE 0x0400
>>>+ #include <shlobj.h>
>>>
>>>First, on MSVC, _WIN32_IE is already defined at that point.
>If you get
>>>around that then processing the include file causes errors.
>>>
>>>
>>
>>Interesting - mingw was supposed to use compatible headers, I thought
>>:-)
>>Can you tru moving the #define up to the top of the file and
>see if that
>>fixes things? So it's pulled before *any* windows include
>file. (My msvc
>>has completely stopped building fromt he commandline. Need to
>fix that,
>>but it's not up right now)
>>
>>
>I surrounded the #define with #ifndef ... #endif. If you agree that
>would be the first fix.
>
>But most errors remained (see my follow up email yesterday)
>
>The error appears to be on line that uses NEAR and complains about it
>... I see that the MinGW windef.h defines NEAR as empty, while
>the MSVC
>windef.h defines it as "near". Don't know if that makes a difference.

Some reading up on MSDN gives this:
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vccore9
8/html/_core_removing_near_and_far_type_declarations.asp

From what I can tell, NEAR is defined to near, which is then defined to
blank in my windef.h (from the platform SDK included in VS2003)

Could it be that we need to include windef.h explicitly, before we
include this one? Worth a try.

//Magnus

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2005-01-09 21:12:38 Re: Home dir changes have broken MSVC builds
Previous Message Andrew Dunstan 2005-01-09 19:25:11 Re: Home dir changes have broken MSVC builds