Re: build error in initdb on win32

From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
To: "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, <pgsql-hackers-win32(at)postgresql(dot)org>
Subject: Re: build error in initdb on win32
Date: 2004-10-11 07:58:56
Message-ID: 6BCB9D8A16AC4241919521715F4D8BCE475E7A@algol.sollentuna.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers-win32

> > >> How about this. If the required functions (which aren't
> > >*too* many) are
> > >> added to libpqdll.def, everything returns to working order.
> > >It does add
> > >> a slight maintainability issue - whenever a new binary
> is using a
> > >> function in libpq never before exported, it has to be added to
> > >> libpqdll.def.
> > >
> > >Yeah, I was assuming we'd have to do that. (Does your
> existing patch
> > >do something different?)
> >
> > Well, my existing patch just changes it to export only what's in
> > libpqdll.def. That's how I came across this problem.
> > I'll polish it up and include all the necessary functions in
> > libpqdll.def, then. There aren't that many, but a couple. I'll also
> > try to work out how to deal with the SSL vs non-SSL DLL
> issue while at it.
>
> Is this going to remove the requirement for pg_dump/Makefile
> to use exec.o on the link line?

I doubt it. All it does is change what is exported from libpq.dll. And
it only *removes* things (which I'm now realising I have to add some
back). So I don't see how it could help with this problem.

//Magnus

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Bruce Momjian 2004-10-11 22:22:57 Need for DLLINIT in Makefile.shlib
Previous Message Bruce Momjian 2004-10-11 02:28:39 Re: build error in initdb on win32