Re: [PATCH] Add pg_get_table_ddl() to reconstruct CREATE TABLE statements

> On Jun 22, 2026, at 22:11, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>
>
> On Mon, Jun 22, 2026 at 7:30 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>
>
> > On Jun 22, 2026, at 20:40, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
> >
> > You're right, and thanks for spotting this. The existing pattern in pg_proc.dat for variadic-text functions (e.g., jsonb_delete, json_extract_path) uses _text at the variadic position in both proargtypes and proallargtypes, with provariadic => 'text'. That is the convention documented by the sanity check in src/test/regress/sql/opr_sanity.sql.
> >
> > The same issue applies to pg_get_role_ddl, pg_get_tablespace_ddl (both variants), and pg_get_database_ddl, but that will require a separate patch.
> >
>
> Thanks for confirming. Then I will file a patch tomorrow to fix those.
>
> I started working on it, but if you want to take the lead, just let me know and I won't send my version over
>

The changes to pg_proc.dat have been in my local tree for some time. Today I also fixed the sanity check in opr_sanity so that it can now report this mismatch. Could you please take a look at my patch [1]?

[1] https://www.postgresql.org/message-id/D41A334E-ED9E-42EE-830D-28D4D36E9317%40gmail.com

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/