Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim, replace, split_part

From: "David E(dot) Wheeler" <david(at)justatheory(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Florents Tselai <florents(dot)tselai(at)gmail(dot)com>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Peter Eisentraut <peter(at)eisentraut(dot)org>
Subject: Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim, replace, split_part
Date: 2025-05-21 18:13:28
Message-ID: 6A995806-5B9C-455C-8923-53A0448893BF@justatheory.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On May 21, 2025, at 14:06, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> No, that wouldn't be too much work, but the issue is that people will
> keep using the _tz versions and when we eventually try to remove them
> those people will complain no matter how prominent we make the
> deprecation notice. If we want to go this route, maybe we should do
> something like:
>
> 1. Add the new versions with a _s suffix or whatever.
>
> 2. Invent a GUC jsonb_tz_warning = { on | off } that advises you to
> use the new functions instead, whenever you use the old ones.
>
> 3. After N years, flip the default value from off to on.
>
> 4. After M additional years, remove the old functions and the GUC.
>
> 5. Still get complaints.

Complainers gonna complain. 🫠

Any idea how widespread the use of the function is? It was added in 17, and I’ve met few who have really dug into the jonpath stuff yet, let alone needed the time zone conversion functionality.

Best,

David

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Jones 2025-05-21 18:22:06 Re: [PoC] XMLCast (SQL/XML X025)
Previous Message Robert Haas 2025-05-21 18:06:17 Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim, replace, split_part