Re: Increase Vacuum ring buffer.

From: Sokolov Yura <funny(dot)falcon(at)postgrespro(dot)ru>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, pgsql-hackers(at)postgresql(dot)org, pgsql-hackers-owner(at)postgresql(dot)org
Subject: Re: Increase Vacuum ring buffer.
Date: 2017-07-21 15:47:05
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2017-07-20 22:51, Tom Lane wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> I think that's a valid point. There are also other concerns here -
>> e.g. whether instead of adopting the patch as proposed we ought to (a)
>> use some smaller size, or (b) keep the size as-is but reduce the
>> maximum fraction of shared_buffers that can be consumed, or (c) divide
>> the ring buffer size through by autovacuum_max_workers. Personally,
>> of those approaches, I favor (b). I think a 16MB ring buffer is
>> probably just fine if you've got 8GB of shared_buffers but I'm
>> skeptical about it when you've got 128MB of shared_buffers.
> WFM. I agree with *not* dividing the basic ring buffer size by
> autovacuum_max_workers. If you have allocated more AV workers, I think
> you expect AV to go faster, not for the workers to start fighting among
> themselves.
> It might, however, be reasonable for the fraction-of-shared-buffers
> limitation to have something to do with autovacuum_max_workers, so that
> you can't squeeze yourself out of shared_buffers if you set that number
> really high. IOW, I think the upthread suggestion of
> min(shared_buffers/8/autovacuum_workers, 16MB) is basically the right
> idea, though we could debate the exact constants.
> regards, tom lane

Attached version is with min(shared_buffers/8/autovacuum_workers, 16MB).

With regards
Sokolov Yura aka funny_falcon
Postgres Professional:
The Russian Postgres Company

Attachment Content-Type Size
0001-Set-total-vacuum-ring-buffer-16MB-v2.patch text/x-diff 2.1 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2017-07-21 16:01:24 Re: [COMMITTERS] pgsql: Add a Gather executor node.
Previous Message Alvaro Herrera 2017-07-21 15:34:32 Re: [COMMITTERS] pgsql: Add a Gather executor node.