Re: Performing partition pruning using row value

From: David Steele <david(at)pgmasters(dot)net>
To: Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>, "kato-sho(at)fujitsu(dot)com" <kato-sho(at)fujitsu(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Performing partition pruning using row value
Date: 2021-04-08 15:04:28
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2/16/21 9:07 AM, Anastasia Lubennikova wrote:
> On 21.07.2020 11:24, kato-sho(at)fujitsu(dot)com wrote:
>>> So, after looking at these functions and modifying this patch, I
>>> would like to add this patch to the next
>> I updated this patch and registered for the next CF .
>> regards,
>> sho kato
> Thank you for working on this improvement. I took a look at the code.
> 1) This piece of code is unneeded:
>             switch (get_op_opfamily_strategy(opno, partopfamily))
>             {
>                 case BTLessStrategyNumber:
>                 case BTLessEqualStrategyNumber:
>                 case BTGreaterEqualStrategyNumber:
>                 case BTGreaterStrategyNumber:
> See the comment for RowCompareExpr, which states that "A RowCompareExpr
> node is only generated for the < <= > >= cases".
> 2) It's worth to add a regression test for this feature.
> Other than that, the patch looks good to me.

This patch has been Waiting on Author for several months, so marking
Returned with Feedback.

Please resubmit to the next CF when you have a new patch.


In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Steele 2021-04-08 15:07:55 Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT
Previous Message Tomas Vondra 2021-04-08 14:57:59 Re: maximum columns for brin bloom indexes