Re: recovery_target_action=pause with confusing hint

From: Sergei Kornilov <sk(at)zsrv(dot)org>
To: movead li <movead(dot)li(at)highgo(dot)ca>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: recovery_target_action=pause with confusing hint
Date: 2020-03-31 09:59:50
Message-ID: 6993181585648248@iva6-161d47f95e63.qloud-c.yandex.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello

> When I test the patch, I find an issue: I start a stream with 'promote_trigger_file'
> GUC valid, and exec pg_wal_replay_pause() during recovery and as below it
> shows success to pause at the first time. I think it use a initialize
> 'SharedPromoteIsTriggered' value first time I exec the pg_wal_replay_pause().

hm. Are you sure this is related to this patch? Could you explain the exact timing? I mean log_statement = all and relevant logs.
Most likely this is expected change by https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=496ee647ecd2917369ffcf1eaa0b2cdca07c8730

My proposal does not change the behavior after this commit, only changing the lines in the logs.

regards, Sergei

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2020-03-31 10:16:48 Re: WAL usage calculation patch
Previous Message Amit Kapila 2020-03-31 09:31:56 Re: WAL usage calculation patch