| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Jeff Davis <pgsql(at)j-davis(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: ICU locale validation / canonicalization |
| Date: | 2023-04-04 13:13:53 |
| Message-ID: | 69625803-0c6b-3d39-a401-05315b26b7e8@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 31.03.23 12:11, Jeff Davis wrote:
> On Thu, 2023-03-30 at 08:59 +0200, Peter Eisentraut wrote:
>> I don't think we should show the notice when the canonicalization
>> doesn't change anything. This is not useful:
>>
>> +NOTICE: using language tag "und-u-kf-upper" for locale "und-u-kf-
>> upper"
>
> Done.
>
>> Also, the message should be phrased more from the perspective of the
>> user instead of using ICU jargon, like
>>
>> NOTICE: using canonicalized form "%s" for locale specification "%s"
>>
>> (Still too many big words?)
>
> Changed to:
>
> NOTICE: using standard form "%s" for locale "%s"
>
>> Needs documentation updates in doc/src/sgml/charset.sgml.
>
> I made a very minor update. Do you have something more specific in
> mind?
This all looks good to me.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jonathan S. Katz | 2023-04-04 13:23:16 | Re: Check whether binaries can be released for s390x |
| Previous Message | Aleksander Alekseev | 2023-04-04 13:08:14 | Re: [PATCH] Clarify the behavior of the system when approaching XID wraparound |