Re: No error checking when reading from file using zstd in pg_dump

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Tomas Vondra <tomas(at)vondra(dot)me>, Evgeniy Gorbanev <gorbanyoves(at)basealt(dot)ru>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: No error checking when reading from file using zstd in pg_dump
Date: 2025-08-24 21:23:52
Message-ID: 693B4307-E0C0-4184-BE9B-7EC83BB6ABC9@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 24 Aug 2025, at 23:21, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>>> On 1 Jul 2025, at 17:42, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> There are some minor typos in the proposed commit message, too.
>
>> It seems that my grasp of the english language went on holiday before I did.
>> The attached v9 is hopefully less terrible.
>
> This thread seems to have faded away, which I fear is my fault.
> I took another look through v9, and it seems fine. Do you want
> to deal with pushing it, or shall I?

Thanks for the review, this one had admittedly slipped my mind. I'll work on
getting it in at the start of the week.

--
Daniel Gustafsson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2025-08-24 22:43:21 Re: Non-reproducible AIO failure
Previous Message Tom Lane 2025-08-24 21:21:33 Re: No error checking when reading from file using zstd in pg_dump