Re: Improve the comparison of NUMERIC data

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Atsushi Ogawa <atsushi(dot)ogawa(at)gmail(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Improve the comparison of NUMERIC data
Date: 2005-11-08 17:34:05
Message-ID: 6936.1131471245@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Atsushi Ogawa <atsushi(dot)ogawa(at)gmail(dot)com> writes:
> An attached patch enables the comparison of Numeric values without
> executing conversion to NumericVar.

This is likely to be broken entirely by the recent proposals to modify
the on-disk representation of Numeric.

Rather than trying to share code, it'd likely be better to make a
separate routine that can directly compare two values in the packed
(on-disk) representation, and modify the externally-callable entry
points to use that. That way avoids imposing constraints on how
different the packed and unpacked representations can be.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Michael Paesold 2005-11-08 21:07:35 Re: Interval aggregate regression failure (expected seems
Previous Message Atsushi Ogawa 2005-11-08 14:37:49 Improve the comparison of NUMERIC data