Re: Support for NSS as a libpq TLS backend

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Jacob Champion <pchampion(at)vmware(dot)com>
Cc: "sfrost(at)snowman(dot)net" <sfrost(at)snowman(dot)net>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "hlinnaka(at)iki(dot)fi" <hlinnaka(at)iki(dot)fi>, "andrew(dot)dunstan(at)2ndquadrant(dot)com" <andrew(dot)dunstan(at)2ndquadrant(dot)com>, "rachelmheaton(at)gmail(dot)com" <rachelmheaton(at)gmail(dot)com>, "thomas(dot)munro(at)gmail(dot)com" <thomas(dot)munro(at)gmail(dot)com>, "michael(at)paquier(dot)xyz" <michael(at)paquier(dot)xyz>, "andres(at)anarazel(dot)de" <andres(at)anarazel(dot)de>
Subject: Re: Support for NSS as a libpq TLS backend
Date: 2021-10-05 13:08:18
Message-ID: 690B28CA-D819-4714-B8F6-54DD6F02722C@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 4 Oct 2021, at 18:14, Jacob Champion <pchampion(at)vmware(dot)com> wrote:
>
> On Fri, 2021-10-01 at 08:55 +0200, Daniel Gustafsson wrote:
>> Ah, that makes perfect sense. I was too focused on hunting in what new was
>> linked against that I overlooked the obvious. Thanks for finding these.
>
> No problem at all :) The exit() check is useful but still a little
> opaque, I think, especially since (from my newbie perspective) there's
> so much of the pgcommon staticlib that is forbidden for use in libpq.

Thanks! These changes looks good. Since you accidentally based this on v43
and not the v44 I posted with the cryptohash fix in, the attached is a v45 with
both your v44 and the previous one, all rebased over HEAD.

--
Daniel Gustafsson https://vmware.com/

Attachment Content-Type Size
v45-0001-nss-Support-libnss-as-TLS-library-in-libpq.patch application/octet-stream 103.2 KB
v45-0002-Refactor-SSL-testharness-for-multiple-library.patch application/octet-stream 11.5 KB
v45-0003-nss-Add-NSS-specific-tests.patch application/octet-stream 57.8 KB
v45-0004-test-check-for-empty-stderr-during-connect_ok.patch application/octet-stream 3.6 KB
v45-0005-nss-pg_strong_random-support.patch application/octet-stream 2.0 KB
v45-0006-nss-Documentation.patch application/octet-stream 35.3 KB
v45-0007-nss-Support-NSS-in-pgcrypto.patch application/octet-stream 24.9 KB
v45-0008-nss-Support-NSS-in-sslinfo.patch application/octet-stream 3.6 KB
v45-0009-nss-Support-NSS-in-cryptohash.patch application/octet-stream 6.1 KB
v45-0010-nss-Build-infrastructure.patch application/octet-stream 21.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2021-10-05 14:17:46 Re: plperl: update ppport.h and fix configure version check
Previous Message Stephen Frost 2021-10-05 12:58:57 Re: Role Self-Administration