| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Xuneng Zhou <xunengzhou(at)gmail(dot)com>, srinath2133(at)gmail(dot)com, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Bug in pg_dump --filter? - Invalid object types can be misinterpreted as valid |
| Date: | 2025-08-05 07:52:15 |
| Message-ID: | 690349FD-8027-4054-B962-75F5F1E06463@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 4 Aug 2025, at 17:18, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
I missed this thread while being on vacation, thanks for finding and fixing
this!
> This also got me thinking, if we simply define keywords as strings of
> non-whitespace characters, maybe we don't need to change the term "keyword"
> to "token" at all. I've updated the patch with that in mind. Thoughts?
Agreed, this should work fine, and it aligns the code somwhat with read_pattern
which is a good thing.
+ * in line buffer. Returns NULL when the buffer is empty or no keyword exists.
Since "is empty" could be interpreted as being a null pointer, maybe we should
add a if (!*line) check (or an Assert) before we dereference the passed in
buffer?
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2025-08-05 08:52:34 | Re: CREATE PUBLICATION with 'publish_generated_columns' parameter specified but unassigned |
| Previous Message | Peter Smith | 2025-08-05 07:22:06 | Re: CREATE PUBLICATION with 'publish_generated_columns' parameter specified but unassigned |