Re: run pgindent on a regular basis / scripted manner

From: Vik Fearing <vik(at)postgresfriends(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Peter Geoghegan <pg(at)bowt(dot)ie>, Andres Freund <andres(at)anarazel(dot)de>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Jelte Fennema <postgres(at)jeltef(dot)nl>, Michael Paquier <michael(at)paquier(dot)xyz>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Jesse Zhang <sbjesse(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Subject: Re: run pgindent on a regular basis / scripted manner
Date: 2023-10-18 13:04:13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 10/17/23 16:23, Tom Lane wrote:
> An alternative I was thinking about after reading your earlier email was
> going back to the status quo ante, but doing the manual tree-wide
> reindents significantly more often than once a year. Adding one at the
> conclusion of each commitfest would be a natural thing to do, for
> instance. It's hard to say what frequency would lead to the least
> rebasing pain, but we know once-a-year isn't ideal.

This is basically how the SQL Committee functions. The Change Proposals
(patches) submitted every meeting (commitfest) are always against the
documents as they exist after the application of papers (commits) from
the previous meeting.

One major difference is that Change Proposals are against the text, and
patches are against the code. It is not dissimilar to people saying
what our documentation should say, and then someone implementing that

So I am in favor of a pgindent run *at least* at the end of each
commitfest, giving a full month for patch authors to rebase before the
next fest.
Vik Fearing

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alena Rybakina 2023-10-18 13:44:08 Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop()
Previous Message Robert Haas 2023-10-18 12:39:03 Re: The danger of deleting backup_label