| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru>, David Steele <david(at)pgmasters(dot)net>, Haozhou Wang <hawang(at)pivotal(dot)io>, Anthony Bykov <a(dot)bykov(at)postgrespro(dot)ru> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Paul Guo <pguo(at)pivotal(dot)io>, Hubert Zhang <hzhang(at)pivotal(dot)io> |
| Subject: | Re: [PATCH] Add missing type conversion functions for PL/Python |
| Date: | 2018-07-12 16:09:01 |
| Message-ID: | 68a01d38-441e-482f-82a7-f0d2f375fa90@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12/07/18 18:06, Nikita Glukhov wrote:
> I have added some cross-type test cases and now almost all new code is covered
> (excluding several error cases which can be triggered only by custom numeric
> type implementations).
Thanks! Some of those new tests actually fail, if you run them against
unpatched master. For example:
SELECT * FROM test_type_conversion_float8_int2(100::float8);
INFO: (100.0, <type 'float'>)
- test_type_conversion_float8_int2
-----------------------------------
- 100
-(1 row)
-
+ERROR: invalid input syntax for integer: "100.0"
+CONTEXT: while creating return value
+PL/Python function "test_type_conversion_float8_int2"
So this patch is making some subtle changes to behavior. I don't think
we want that.
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2018-07-12 16:18:41 | Re: [HACKERS] Re: [COMMITTERS] pgsql: Remove pgbench "progress" test pending solution of its timing is (fwd) |
| Previous Message | Andrey Borodin | 2018-07-12 16:06:38 | Re: GiST VACUUM |