Re: Stats Collector Error 7.4beta1 and 7.4beta2

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: andrew(at)dunslane(dot)net
Cc: JanWieck(at)yahoo(dot)com, Q(at)ping(dot)be, pgman(at)candle(dot)pha(dot)pa(dot)us, matthew(at)zeut(dot)net, akavan(at)cox(dot)net, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Stats Collector Error 7.4beta1 and 7.4beta2
Date: 2003-09-06 02:26:19
Message-ID: 6885.1062815179@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

<andrew(at)dunslane(dot)net> writes:
> This analysis makes sense - I think using memcmp is clearly wrong here.

Yeah, now that I think about it, we're betting on the kernel to
faithfully zero all unused bits in addrinfo structures. In an ideal
world, all kernels would do that, but in the real world it seems like
a losing bet.

I could go for Jan's idea of putting a random key into the messages,
if anyone feels that we should not trust to the kernel to enforce the
packet source address restriction. But the memcmp() test seems a clear
loser given today's discussions.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2003-09-06 11:25:18 Re: Notices for redundant operations
Previous Message andrew 2003-09-06 01:09:19 Re: Stats Collector Error 7.4beta1 and 7.4beta2