| From: | Gilles Darold <gilles(dot)darold(at)dalibo(dot)com> |
|---|---|
| To: | "Karl O(dot) Pinc" <kop(at)meme(dot)com> |
| Cc: | Christoph Berg <myon(at)debian(dot)org>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Shulgin, Oleksandr" <oleksandr(dot)shulgin(at)zalando(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch to implement pg_current_logfile() function |
| Date: | 2016-11-28 20:00:47 |
| Message-ID: | 687ab3a1-ee7e-3bf4-4f3d-055b6b005919@dalibo.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Le 28/11/2016 à 18:54, Karl O. Pinc a écrit :
> Hi Gilles,
>
> On Sun, 27 Nov 2016 21:54:46 +0100
> Gilles Darold <gilles(dot)darold(at)dalibo(dot)com> wrote:
>
>> I've attached the v15 of the patch that applies your changes/fixes and
>> remove the call to strtok().
> I like the idea of replacing the strtok() call with sscanf()
> but I see problems.
>
> It won't work if log_filename begins with a space because
> (the docs say) that a space in the sscanf() format represents
> any amount of whitespace.
Right
> As written, there's a potential buffer overrun in log_format.
> You could fix this by making log_format as large as lbuffer,
> but this seems clunky.
Sorry, Isee that I forgot to apply the control in number of character
read by sscanf.
The problem about white space make me though that the use of sscanf is
not the right solution, I will rewrite this part but I can not do that
before the end of the week.
--
Gilles Darold
Consultant PostgreSQL
http://dalibo.com - http://dalibo.org
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Corey Huinker | 2016-11-28 20:03:44 | Re: PSQL commands: \quit_if, \quit_unless |
| Previous Message | Pavel Stehule | 2016-11-28 20:00:41 | Re: PSQL commands: \quit_if, \quit_unless |