Re: Adding REPACK [concurrently]

Antonin Houska <ah(at)cybertec(dot)at> wrote:

> Antonin Houska <ah(at)cybertec(dot)at> wrote:
>
> > Mihail Nikalayeu <mihailnikalayeu(at)gmail(dot)com> wrote:
> > > ------------
> > >
> > > > attrs = palloc0_array(Datum, desc->natts);
> > > > isnull = palloc0_array(bool, desc->natts);
> > >
> > > It looks like there is a memory leak with those arrays.
> >
> > I suppose you mean store_change(). Yes, I tried to free the individual chunks
> > and forgot these. The next version uses a new, per-change memory context.
>
> I realize now that I forgot to reset the context at the end of the
> function. I'll fix that in the next version (which will probably be posted
> rather soon).

This is it. One more diff added, to engage BulkInsertState.

--
Antonin Houska
Web: https://www.cybertec-postgresql.com