| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | Zoltan Boszormenyi <zb(at)cybertec(dot)at>, Gregory Stark <stark(at)enterprisedb(dot)com>, pgsql-patches(at)postgresql(dot)org, Hans-Juergen Schoenig <hs(at)cybertec(dot)at>, Magnus Hagander <magnus(at)hagander(dot)net> |
| Subject: | Re: float4/float8/int64 passed by value with tsearch fixup |
| Date: | 2008-04-18 19:14:48 |
| Message-ID: | 6856.1208546088@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> I assume this is just some dumb portability mistake on my part ... or
> perhaps the fact that the functions are still using v0 fmgr convention?
Since they're v0, they'd have to explicitly know about the pass-by-ref
status of float4.
Did this patch include a compile-time choice of whether things could
remain pass-by-ref? I rather imagine that some people out there will
prefer to stay that way instead of fix their old v0 code.
In the meantime, converting contrib/seg to v1 might be the best
solution.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2008-04-18 19:23:04 | Re: float4/float8/int64 passed by value with tsearch fixup |
| Previous Message | Alvaro Herrera | 2008-04-18 19:10:08 | Re: float4/float8/int64 passed by value with tsearch fixup |