Re: Safeguards against incorrect fd flags for fsync()

From: Michael Banck <mbanck(at)gmx(dot)net>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Safeguards against incorrect fd flags for fsync()
Date: 2025-06-10 21:09:31
Message-ID: 68489f0b.050a0220.21ce72.f4b3@mx.google.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

one more thing:

On Tue, Jun 10, 2025 at 12:26:48PM +0200, Michael Banck wrote:
> The better way might be to mask the flags with O_ACCMODE and then just
> check what you want, like in the attached.

I forgot to mention it in the patch, but Samuel Thibault reviewed the
patch and suggested improvements to the point where he should probably
be credited as co-author but at least as reviewer should this be
accepted.

Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-06-10 21:26:46 Re: Cleaning up historical portability baggage
Previous Message Michael Banck 2025-06-10 21:05:11 Re: Cleaning up historical portability baggage