tighten generic_option_name, or store more carefully in catalog?

From: Chapman Flack <jcflack(at)acm(dot)org>
To: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: tighten generic_option_name, or store more carefully in catalog?
Date: 2025-05-23 21:40:00
Message-ID: 6830EB30.8090904@acm.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

generic_option_name is a ColLabel, therefore a fully general SQL identifier.

But a command like CREATE FOREIGN DATA WRAPPER w ... OPTIONS ("a=b" 'c=d')
stores {a=b=c=d} in fdwoptions, from which the original intent can't be
recovered.

Should generic_option_name be restricted to be a regular identifier,
or allowed to be a delimited identifier but with = forbidden within it,
or should it be represented as delimited in the catalog when necessary
so it can be recovered faithfully?

SQL rules would also make its case-sensitivity dependent on faithfully
recovering whether it was delimited or not.

Regards,
-Chap

Browse pgsql-hackers by date

  From Date Subject
Next Message Mihail Nikalayeu 2025-05-23 21:59:00 Re: Revisiting {CREATE INDEX, REINDEX} CONCURRENTLY improvements
Previous Message Tomas Vondra 2025-05-23 21:29:18 Re: [WIP]Vertical Clustered Index (columnar store extension) - take2