Re: HEAPDEBUGALL is broken

Alexander Lakhin <exclusion(at)gmail(dot)com> writes:
> 21.04.2020 21:01, Peter Eisentraut wrote:
>> Do you have a proposed patch?

> As this is broken at least since the invention of the generational
> allocator (2017-11-23, a4ccc1ce), I believe than no one uses this (and
> slab is broken too). Nonetheless, HAVE_ALLOCINFO in aset.c is still
> working, so it could be leaved alone, though the output too chatty for
> general use (`make check` produces postmaster log of size 3.8GB). I
> think someone would still need to insert some extra conditions to use
> that or find another way to debug memory allocations.

> So I would just remove this debug macro. The proposed patch is attached.

I didn't review this in close detail, but I think it's a good idea.
We have better memory-use-analysis tools these days, such as valgrind,
so it's no surprise that nobody is using this old code.

regards, tom lane