Re: [PATCHES] YADP - Yet another Dependency Patch

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Rod Taylor" <rbt(at)zort(dot)ca>
Cc: "Hackers List" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] YADP - Yet another Dependency Patch
Date: 2002-04-18 05:24:37
Message-ID: 6821.1019107477@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

"Rod Taylor" <rbt(at)zort(dot)ca> writes:
>> 3. Isn't there a better way to find the initial dependencies? That
>> SELECT is truly ugly, and more to the point is highly likely to
>> break anytime someone rearranges the catalogs.

> I'm having a really hard time coming up with a good method for this.

Well, do we actually need an *accurate* representation of the
dependencies? You seemed to like my idea of pinning essential stuff,
and in reality all of the initial catalog structures ought to be pinned.
Maybe it would be sufficient to just make "pinned" entries for
everything that appears in the initial catalogs. Someone who's really
intent on manually deleting, say, the "box" datatype could be expected
to be bright enough to figure out how to remove the pg_depends entry
that's preventing him from doing so.

(There are a very small number of things that are specifically intended
to be droppable, like the "public" namespace, but seems like excluding
that short list from the pg_depends entries would be more maintainable
than the approach you've got now.)

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2002-04-18 05:31:41 Re: timeout implementation issues
Previous Message Bruce Momjian 2002-04-18 05:03:33 Re: regexp character class locale awareness patch

Browse pgsql-patches by date

  From Date Subject
Next Message David Wheeler 2002-04-18 05:42:44 Re: Mac OS X Startup Script
Previous Message Bruce Momjian 2002-04-18 05:02:05 Re: regression tests for ALTER TABLE ... DEFAULT