| From: | btnakamichin <btnakamichin(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Feature improvement of tab completion for DEALLOCATE |
| Date: | 2020-09-25 06:18:20 |
| Message-ID: | 680a8129485eb754f31ad0ccc1f7151f@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
2020-09-25 14:30 に Fujii Masao さんは書きました:
> On 2020/09/25 13:45, btnakamichin wrote:
>> Hello!
>>
>> I’d like to improve the deallocate tab completion.
>>
>> The deallocate tab completion can’t complement “ALL”. Therefore, this
>> patch fixes the problem.
>
> Thanks for the patch! It looks basically good, but I think it's better
> to add newline just before UNION to avoid long line, as follows.
>
> -
> COMPLETE_WITH_QUERY(Query_for_list_of_prepared_statements);
> +
> COMPLETE_WITH_QUERY(Query_for_list_of_prepared_statements
> + " UNION SELECT
> 'ALL'");
>
> Regards,
Thank you, I appreciate your comment.
I have attached pattch with newline.
Regards,
NaokiNskamichi
| Attachment | Content-Type | Size |
|---|---|---|
| fix_tab_complete_deallocate_v2.patch | text/x-diff | 557 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yang, Rong | 2020-09-25 06:28:09 | Problem of ko.po on branch REL9_5_STABLE |
| Previous Message | Ashutosh Sharma | 2020-09-25 06:12:29 | Re: Logical replication from PG v13 and below to PG v14 (devel version) is not working. |