From: | "Euler Taveira" <euler(at)eulerto(dot)com> |
---|---|
To: | "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Cc: | "vignesh C" <vignesh21(at)gmail(dot)com>, "Michael Paquier" <michael(at)paquier(dot)xyz>, "Peter Eisentraut" <peter(at)eisentraut(dot)org>, "Andres Freund" <andres(at)anarazel(dot)de>, "Ashutosh Bapat" <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, "Amit Kapila" <amit(dot)kapila16(at)gmail(dot)com>, "Shlok Kyal" <shlok(dot)kyal(dot)oss(at)gmail(dot)com> |
Subject: | Re: speed up a logical replica setup |
Date: | 2024-02-01 03:05:23 |
Message-ID: | 6793c99e-9bb4-4395-8e00-21d7074445c9@app.fastmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Jan 31, 2024, at 11:09 PM, Hayato Kuroda (Fujitsu) wrote:
> >
> Why? Are you suggesting that the dry run mode covers just the verification
> part? If so, it is not a dry run mode. I would expect it to run until the end
> (or until it accomplish its goal) but *does not* modify data. For pg_resetwal,
> the modification is one of the last steps and the other ones (KillFoo
> functions) that are skipped modify data. It ends the dry run mode when it
> accomplish its goal (obtain the new control data values). If we stop earlier,
> some of the additional steps won't be covered by the dry run mode and a failure
> can happen but could be detected if you run a few more steps.
> >
>
> Yes, it was my expectation. I'm still not sure which operations can detect by the
> dry_run, but we can keep it for now.
The main goal is to have information for troubleshooting.
>
> Good point. I included a check for pg_create_subscription role and CREATE
> privilege on the specified database.
> >
>
> Not sure, but can we do the replication origin functions by these privilege?
> According to the doc[1], these ones seem not to be related.
Hmm. No. :( Better add this check too.
--
Euler Taveira
EDB https://www.enterprisedb.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2024-02-01 03:24:42 | Re: Flushing large data immediately in pqcomm |
Previous Message | Richard Guo | 2024-02-01 02:54:02 | Re: Oversight in reparameterize_path_by_child leading to executor crash |