Re: pgindent issue with EXEC_BACKEND-only typedefs

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgindent issue with EXEC_BACKEND-only typedefs
Date: 2007-12-16 23:53:22
Message-ID: 679.1197849202@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Alvaro Herrera wrote:
>> It seems pgindent is not considering EXEC_BACKEND typedefs.

> Yep. The cause is that find_typedefs actually pulls the typedef out of
> the debugged-enabled binary, and on Unix those functions aren't used by
> default. This is spelled out in the pgindent/README in CVS.

> I could just EXEC_BACKEND in the debug build I use but I suppose there
> are other typedef I am missing as well. Any idea on a more
> comprehensive solution to finding typedefs?

I guess that explains why plpython.c and most of contrib have similar
problems.

If you want to do this on the basis of precompiled code, you need to
enable every optional feature in your build, and include the PLs and
contrib modules not only the core backend.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2007-12-17 00:47:40 Re: test
Previous Message Tom Lane 2007-12-16 17:31:11 Re: Negative LIMIT and OFFSET?