Re: Runtime pruning problem

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
Cc: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Yuzuko Hosoya <hosoya(dot)yuzuko(at)lab(dot)ntt(dot)co(dot)jp>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Runtime pruning problem
Date: 2019-07-30 22:27:19
Message-ID: 6779.1564525639@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> writes:
> The part I wouldn't mind another set of eyes on is the ruleutils.c
> changes.

Um, sorry for not getting to this sooner.

What I had in mind was to revert 1cc29fe7c's ruleutils changes
entirely, so that ruleutils deals only in Plans not PlanStates.
Perhaps we've grown some code since then that really needs the
PlanStates, but what is that, and could we do it some other way?
I'm not thrilled with passing both of these around, especially
if the PlanState sometimes isn't there, meaning that no code in
ruleutils could safely assume it's there anyway.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-07-30 22:29:53 Re: AW: AW: Adding column "mem_usage" to view pg_prepared_statements
Previous Message Tomas Vondra 2019-07-30 22:17:40 Re: Adding column "mem_usage" to view pg_prepared_statements