Re: [PATCH] Correct RangeTblEntry.join_using_alias comment to reflect field order

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: Steve Lau <stevelauc(at)outlook(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Correct RangeTblEntry.join_using_alias comment to reflect field order
Date: 2025-09-21 22:41:23
Message-ID: 6761DC8A-6B7E-4B7F-95A4-E7CD32E2C2A8@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Sep 21, 2025, at 22:48, Steve Lau <stevelauc(at)outlook(dot)com> wrote:
>
> Hi hackers!
>
> Found a tiny incorrect comment of RangeTblEntry, field "alias" is actually above "join_using_alias", so the code comment could be updated to reflect the current field order:
>
> > join_using_alias is an alias clause attached directly to JOIN/USING. It is different from the alias field (below) in that it does not hide the
>
> Regards,
> steve
>
> <v1-0001-Correct-RangeTblEntry.join_using_alias-comment-to-re.patch>

“alias” is the second field of structure RangeTblEntry, so it should be above “join_using_alias”.

The change looks good to me.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-09-21 22:48:06 Re: GNU/Hurd portability patches
Previous Message Michael Paquier 2025-09-21 22:18:27 Re: Meson0.57.2 setup failed with option -Duuid=ossp