| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, bossartn(at)amazon(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Allow pg_signal_backend members to use pg_log_backend_memory_stats(). |
| Date: | 2021-10-25 20:42:07 |
| Message-ID: | 66fbd8a7b7b0037c9e1df48b41941aa587c67f4d.camel@j-davis.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 2021-10-25 at 16:10 +0900, Michael Paquier wrote:
> Hmm. Why don't you split the patch into two parts that can be
> discussed separately then? There would be one to remove all the
> superuser() checks you can think of, and a potential second to grant
> those function's execution to some system role.
Good idea. Attached a patch to remove the superuser check on
pg_log_backend_memory_contexts(), except in the case when trying to log
memory contexts of a superuser backend.
Using pg_signal_backend does not seem to be universally acceptable, so
I'll just drop the idea of granting to that predefined role.
Regards,
Jeff Davis
| Attachment | Content-Type | Size |
|---|---|---|
| pg-log-memory-contexts.diff | text/x-patch | 6.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2021-10-25 20:42:23 | Re: Assorted improvements in pg_dump |
| Previous Message | Bossart, Nathan | 2021-10-25 20:38:44 | Re: parallelizing the archiver |