Prepping for annual pgindent run

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Prepping for annual pgindent run
Date: 2026-05-05 18:39:50
Message-ID: 669384.1778006390@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I propose to do our annual pgindent run sometime pretty soon,
perhaps next week after the minor-release dust has settled.

One thing to be done is to update src/tools/pgindent/typedefs.list
from the canonical list constructed by the buildfarm. We've been
pretty good about maintaining that file manually, but not perfect,
so this has a few small effects --- see attached for what that
would look like today.

I also propose applying the pgindent patches discussed in [1] and [2],
which would have rather larger effects. [1] improves formatting of
multiline comment blocks. 99% of the changes it would cause look like

@@ -933,7 +933,8 @@ _PG_init(void)
MarkGUCPrefixReserved("isn");
}

-/* isn_out
+/*
+ * isn_out
*/
PG_FUNCTION_INFO_V1(isn_out);
Datum

While that's not that big a deal, it improves style uniformity since
most of our multiline comments do not have any text on the first line.

[2] adds a space between comma and an immediately following period,
which mostly affects variadic functions:

@@ -147,7 +147,7 @@ px_set_debug_handler(void (*handler) (const char *))
}

void
-px_debug(const char *fmt,...)
+px_debug(const char *fmt, ...)
{
va_list ap;

It also helps a few struct constructors:

@@ -62,7 +62,7 @@ struct RBTree

static RBTNode sentinel =
{
- .color = RBTBLACK,.left = RBTNIL,.right = RBTNIL,.parent = NULL
+ .color = RBTBLACK, .left = RBTNIL, .right = RBTNIL, .parent = NULL
};

I don't see any places where it makes anything worse, and the
improvement in variadic functions is quite pleasing IMO.
So I think we should do that too.

We also have pgperltidy, renumber_oids.pl, and copyright.pl to
run sometime before beta1. Might as well do those at the same
time.

regards, tom lane

[1] https://www.postgresql.org/message-id/flat/CAJ7c6TPQ0kkHQG-AqeAJ3PV_YtmDzcc7s+_V4=t+xgSnZm1cFw(at)mail(dot)gmail(dot)com
[2] https://www.postgresql.org/message-id/flat/c3327be8-09e2-46a1-88b4-228a339d6916%40proxel.se

Attachment Content-Type Size
update-typedefs-list-20260505.patch text/x-diff 9.7 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Lakhin 2026-05-05 19:00:00 Re: Improving tracking/processing of buildfarm test failures
Previous Message Andreas Karlsson 2026-05-05 18:14:53 Re: Improve pgindent's formatting named fields in struct literals and varidic functions