| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Ashwin Agrawal <aagrawal(at)pivotal(dot)io>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Paul Guo <paulguo(at)gmail(dot)com> |
| Subject: | Re: Missing error_context_stack = NULL in AutoVacWorkerMain() |
| Date: | 2019-10-21 05:01:50 |
| Message-ID: | 6688.1571634110@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Mon, Oct 21, 2019 at 12:47:40AM -0400, Tom Lane wrote:
>> This seems like a real and possibly serious bug to me. Backend sigsetjmp
>> callers *must* clear error_context_stack (or restore it to a previous
>> value), because if it isn't NULL it's surely pointing at garbage, ie a
>> local variable that's no longer part of the valid stack.
> Sure. From my recollection of memories we never set it in autovacuum
> code paths (including index entry deletions), so I don't think that we
> have an actual live bug here.
Uh ... what about, say, auto-analyze on an expression index? That
could call user-defined PL functions and thus reach just about all
of the backend.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-10-21 05:03:47 | Re: Fix of fake unlogged LSN initialization |
| Previous Message | Michael Paquier | 2019-10-21 04:56:52 | Re: Missing error_context_stack = NULL in AutoVacWorkerMain() |