Re: pg_upgrade fails with non-standard ACL

From: Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>
To: Arthur Zakirov <zaartur(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Grigory Smolkin <g(dot)smolkin(at)postgrespro(dot)ru>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pg_upgrade fails with non-standard ACL
Date: 2020-06-08 15:44:23
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 06.04.2020 19:40, Anastasia Lubennikova wrote:
> On 06.04.2020 16:49, Anastasia Lubennikova wrote:
>> New version of the patch is attached. I fixed several issues in the
>> check_for_changed_signatures().
>> Now it passes check without "test_rename_catalog_objects" and fails
>> (generates script) with it. Test script
>> demonstrates this.
>> The only known issue left is the usage of pg_identify_object(),
>> though I don't see a problem here with object types that this patch
>> involves.
>> As I updated the code, I will leave this patch in Need Review.
> One more fix for free_acl_infos().
> Thanks to cfbot.
One more update.
In this version I rebased test patches,  added some more comments, fixed
memory allocation issue and also removed code that handles ACLs on
languages. They require a lot of specific handling, while I doubt that
their signatures, which consist of language name only, are subject to
change in any future versions.

Anastasia Lubennikova
Postgres Professional:
The Russian Postgres Company

Attachment Content-Type Size
pg_upgrade_ACL_check_v9.patch text/x-patch 13.9 KB application/x-shellscript 3.1 KB
test_rename_catalog_objects_v9 text/plain 49.5 KB
test_add_acl_to_catalog_objects.sql application/sql 436 bytes

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Odin Ugedal 2020-06-08 15:46:39 [PATCH] Add support for choosing huge page size
Previous Message Justin Pryzby 2020-06-08 15:40:45 Re: should CREATE INDEX ON partitioned_table call PreventInTransactionBlock() ?