| From: | "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add Information during standby recovery conflicts |
| Date: | 2020-10-12 07:05:05 |
| Message-ID: | 6670629c-58de-0d51-7102-58b07dad6a9a@amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 10/4/20 4:10 PM, Alvaro Herrera wrote
>> +extern const char *get_procsignal_reason_desc(ProcSignalReason reason)
>> + {
>> + const char *reasonDesc = "unknown reason";
>> +
>> + switch (reason)
>> + {
>> + case PROCSIG_RECOVERY_CONFLICT_BUFFERPIN:
>> + reasonDesc = "buffer pin";
>> + break;
> It doesn't work to construct sentences from pieces, for translatability
> reasons. Maybe you can return the whole errmsg sentence from this
> routine instead.
>
Thanks for the feedback!
Enclosed a new version that take care of it.
Bertrand
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0005-Add-Standby-Recovery-Conflicts-BlockedOnly-Info.patch | text/plain | 11.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Nancarrow | 2020-10-12 07:07:19 | Re: Parallel INSERT (INTO ... SELECT ...) |
| Previous Message | Masahiko Sawada | 2020-10-12 06:39:51 | Re: speed up unicode normalization quick check |