Re: Add Information during standby recovery conflicts

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com>
Cc: Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add Information during standby recovery conflicts
Date: 2020-10-04 14:10:34
Message-ID: 20201004141034.GA6361@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> +extern const char *get_procsignal_reason_desc(ProcSignalReason reason)
> + {
> + const char *reasonDesc = "unknown reason";
> +
> + switch (reason)
> + {
> + case PROCSIG_RECOVERY_CONFLICT_BUFFERPIN:
> + reasonDesc = "buffer pin";
> + break;

It doesn't work to construct sentences from pieces, for translatability
reasons. Maybe you can return the whole errmsg sentence from this
routine instead.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-10-04 17:29:41 Buglets in equivclass.c
Previous Message Drouvot, Bertrand 2020-10-04 11:48:22 Re: Add Information during standby recovery conflicts