Re: pgsql: Change Windows rename and unlink substitutes so that they time

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>
Cc: pgsql-hackers(at)postgresql(dot)org, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Change Windows rename and unlink substitutes so that they time
Date: 2007-01-10 14:17:19
Message-ID: 6664.1168438639@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> writes:
> Is there any reason for not back porting the fix into 8.1?

I didn't think it was adequately tested, and I'm not in a position to
test it. (Note that a lack of 8.2 bug reports isn't a sufficient test,
since I think we whacked related code around for 8.2 --- you'd need to
actually test it in context in 8.1 ...)

>> Change Windows rename and unlink substitutes so that they time out after
>> 30 seconds instead of retrying forever. Also modify xlog.c so that if
>> it fails to rename an old xlog segment up to a future slot, it will
>> unlink the segment instead. Per discussion of bug #2712, in which it
>> became apparent that Windows can handle unlinking a file that's being
>> held open, but not renaming it.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2007-01-10 18:06:05 pgsql: Change the planner-to-executor API so that the planner tells the
Previous Message Tatsuo Ishii 2007-01-10 10:22:31 Re: pgsql: Change Windows rename and unlink

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-01-10 14:28:34 Re: Operator family docs
Previous Message Tatsuo Ishii 2007-01-10 10:55:18 Re: Request for review: tsearch2 patch