Re: pgsql: Support arrays over domains.

From: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Support arrays over domains.
Date: 2017-09-30 19:37:20
Message-ID: 664a27a2-a186-addc-5102-d52109496340@2ndQuadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 09/30/2017 03:32 PM, Tom Lane wrote:
> Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> writes:
>> We seem to have caused a problem with pg_upgrade :-(
>> pg_restore: [archiver (db)] could not execute query: ERROR:  pg_type
>> array OID value not set when in binary upgrade mode
>> Here we're upgrading from 9.2 to HEAD. Of course, there isn't an array
>> oid for the domain in 9.2.
> Hmm. That's pretty annoying. We could certainly go ahead and assign
> some unused type OID to the new array type, but the receiving backend
> can't really do that, since it doesn't know which type OIDs will be
> assigned later in the dump file.
>
> Maybe we could put the burden on pg_upgrade (pg_dump --binary-upgrade)
> to select an OID that's not in use in the source database.
>
>

Yes, I think we'll have to do something like that.

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-09-30 21:05:12 pgsql: Fix pg_dump to assign domain array type OIDs during pg_upgrade.
Previous Message Tom Lane 2017-09-30 19:32:43 Re: pgsql: Support arrays over domains.